mahara-contributors team mailing list archive
-
mahara-contributors team
-
Mailing list archive
-
Message #35386
[Bug 1531610] A change has been merged
Reviewed: https://reviews.mahara.org/6478
Committed: https://git.mahara.org/mahara/mahara/commit/3f24446a12501f19032ad02e71888bd7f096364b
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch: 16.04_STABLE
commit 3f24446a12501f19032ad02e71888bd7f096364b
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date: Thu Jan 7 11:11:12 2016 +1300
Bug 1531610: Sorting out where viewsperpage should be used
Made a centeralised function so that we can use 'viewsperpage' only
for the different pages lists. And have 'itemsperpage' for certain
admin lists.
behatnotneeded
Change-Id: Ie8b49bdc0d86ef49f66e9a1bf09799e6bc21484b
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit 4676d7b2f9cbd86008b9e1f6725125452f18470b)
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1531610
Title:
Clean up inconsistencies in the paginators
Status in Mahara:
Fix Committed
Status in Mahara 15.10 series:
Fix Released
Status in Mahara 16.04 series:
Fix Released
Status in Mahara 16.10 series:
Fix Committed
Bug description:
Now that we have the paginators behaving with the same underlying code
there has arisen some issues with the optional variables each
paginator can use.
These issues include:
- pages using jump links opiton but not collections
Need to make it consistent
- Some places using limit per page from the get_account_preference($USER->get('id'), 'viewsperpage'); variable while other are set to the default 10 per page.
Need to only use the account preference for portfolio/group/institution/site pages and not elsewhere
Need to also have it so that if the page has less than 10 results to ignore the user preference
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1531610/+subscriptions
References