mahara-contributors team mailing list archive

[Mahara Bot <1592559@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/6600
Committed: https://git.mahara.org/mahara/mahara/commit/b05bf1b92d39708c9e54ab1b084e674c16a6a1fb
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit b05bf1b92d39708c9e54ab1b084e674c16a6a1fb
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Wed Jun 15 08:42:16 2016 +1200

Bug 1592559: Allow the login errors to appear above in login box.

behatnotneeded

Change-Id: I6acee18adefde9f8fcc805b31140a92fe3554c5f
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1592559

Title:
  Login eror message shown twice

Status in Mahara:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  The error "There was an error with submitting this form. Please check
  the marked fields and try again." is shown twice.

  This is because the login pieform is created / submitted twice to
  handle all the different auth complexity.

  The easiest way to fix this is to take the form with 'login_submitted'
  variable in it and get it to display the error message within the
  login box itself.

  So the two messages still exist but they make more sense now

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1592559/+subscriptions