mahara-contributors team mailing list archive

[Mahara Bot <1595408@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/6613
Committed: https://git.mahara.org/mahara/mahara/commit/d1f63b580a2cf60377de127751042c1c52dd537f
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit d1f63b580a2cf60377de127751042c1c52dd537f
Author: Ghada El-Zoghbi <ghada@xxxxxxxxxxxxxxx>
Date:   Thu Jun 23 16:35:24 2016 +1000

bug #1595408: When calling the render_self() functin ensure a parameter
is passed.

behatnotneeded

Change-Id: I4972d8c4c225a6dfa442744c2fb02782ecebdbc5

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1595408

Title:
  Export a page with comments raises an error

Status in Mahara:
  Fix Committed

Bug description:
  Mahara: 16.04.1
  DB: Postgres
  Browser: Firefox
  OS: Linux

  When exporting a page with comments, the following error occurs:

  <div class="backtrace">[WAR] 2b (artefact/comment/lib.php:899) Missing
  argument 1 for ArtefactTypeComment::render_self(), called in /var/www
  /mahara-site/artefact/comment/export/leap/lib.php on line 66 and
  defined</div>

  <div class="backtrace"><strong>Call stack (most recent
  first):</strong> <ul><li><span style="color:#933;"></span><span
  style="color:#060;"></span><span
  style="color:#339;">log_message</span><span
  style="color:#060;">(</span><span style="color:#f00;">&quot;Missing
  argument 1 for ArtefactTypeComment::render...&quot;, 8, true, true,
  &quot;/var/www/mahara-site/artefact/comment/lib.php&quot;,
  899</span><span style="color:#060;">)</span> at <strong>/var/www
  /mahara-site/lib/errors.php:489</strong></li><li><span
  style="color:#933;"></span><span style="color:#060;"></span><span
  style="color:#339;">error</span><span
  style="color:#060;">(</span><span style="color:#f00;">2, &quot;Missing
  argument 1 for ArtefactTypeComment::render...&quot;, &quot;/var/www
  /mahara-site/artefact/comment/lib.php&quot;, 899, array(size
  0)</span><span style="color:#060;">)</span> at <strong>/var/www
  /mahara-site/artefact/comment/lib.php:899</strong></li><li><span
  style="color:#933;">ArtefactTypeComment</span><span
  style="color:#060;">-&gt;</span><span
  style="color:#339;">render_self</span><span
  style="color:#060;">(</span><span style="color:#f00;"></span><span
  style="color:#060;">)</span> at <strong>/var/www/mahara-
  site/artefact/comment/export/leap/lib.php:66</strong></li><li><span
  style="color:#933;">LeapExportElementComment</span><span
  style="color:#060;">-&gt;</span><span
  style="color:#339;">get_content</span><span
  style="color:#060;">(</span><span style="color:#f00;"></span><span
  style="color:#060;">)</span> at <strong>/var/www/mahara-
  site/export/leap/lib.php:742</strong></li><li><span
  style="color:#933;">LeapExportElement</span><span
  style="color:#060;">-&gt;</span><span
  style="color:#339;">assign_smarty_vars</span><span
  style="color:#060;">(</span><span style="color:#f00;"></span><span
  style="color:#060;">)</span> at <strong>/var/www/mahara-
  site/export/leap/lib.php:555</strong></li><li><span
  style="color:#933;">PluginExportLeap</span><span
  style="color:#060;">-&gt;</span><span
  style="color:#339;">export_artefacts</span><span
  style="color:#060;">(</span><span style="color:#f00;"></span><span
  style="color:#060;">)</span> at <strong>/var/www/mahara-
  site/export/leap/lib.php:136</strong></li><li><span
  style="color:#933;">PluginExportLeap</span><span
  style="color:#060;">-&gt;</span><span
  style="color:#339;">export</span><span
  style="color:#060;">(</span><span style="color:#f00;"></span><span
  style="color:#060;">)</span> at <strong>/var/www/mahara-
  site/export/download.php:98</strong></li></div>

  
  Digging around. It's due to the call to the render_self() not including a variable - i.e. array() - when nothing is to be passed to the function.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1595408/+subscriptions