mahara-contributors team mailing list archive

[Aaron Wells <1599414@xxxxxxxxxxxxxxxxxx>]

This didn't show up in our automated testing because we don't do "make
ssphp" on Jenkins.

We should probably just bundle together a generic "make" or "make build"
step that adds *all* the build steps. So currently, it would be the same
as doing "make css" and "make ssphp", but potentially it could expand in
the future if we start adding more stuff.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1599414

Title:
  New composer-managed SimpleSAML breaks PHPUnit tests.

Status in Mahara:
  Confirmed

Bug description:
  While writing a PHPUnit test for one of my patches, I noticed that the
  new composer-managed SimpleSAML, if present, breaks "make phpunit",
  because it contains some phpunit tests that get detected but are
  lacking the proper stuff to make them run correctly.

  To replicate:

  1. Install the SimpleSAMLPHP library by doing "make ssphp"
  2. Run phpunit tests by doing "make phpunit"

  Expected result: tests run with no failures
  Actual result: Tests fail out with this error message

  PHP Fatal error:  Class 'SimpleSAML_Auth_ProcessingFilter' not found in /home/aaronw/www/mahara/htdocs/auth/saml/extlib/simplesamlphp/modules/exampleauth/lib/Auth/Process/RedirectTest.php on line 7
  PHP Stack trace:
  PHP   1. {main}() /home/aaronw/www/mahara/external/vendor/phpunit/phpunit/composer/bin/phpunit:0
  PHP   2. PHPUnit_TextUI_Command::main() /home/aaronw/www/mahara/external/vendor/phpunit/phpunit/composer/bin/phpunit:63
  PHP   3. PHPUnit_TextUI_Command->run() /home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/TextUI/Command.php:129
  PHP   4. PHPUnit_Runner_BaseTestRunner->getTest() /home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/TextUI/Command.php:150
  PHP   5. PHPUnit_Framework_TestSuite->addTestFiles() /home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/Runner/BaseTestRunner.php:96
  PHP   6. PHPUnit_Framework_TestSuite->addTestFile() /home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/Framework/TestSuite.php:416
  PHP   7. PHPUnit_Util_Fileloader::checkAndLoad() /home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/Framework/TestSuite.php:355
  PHP   8. PHPUnit_Util_Fileloader::load() /home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/Util/Fileloader.php:76
  PHP   9. include_once() /home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/Util/Fileloader.php:92

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1599414/+subscriptions