mahara-contributors team mailing list archive

[Mahara Bot <1599404@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/6661
Committed: https://git.mahara.org/mahara/mahara/commit/3fa968a0162f84a137df2fa9b40f5436a4e1df21
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 3fa968a0162f84a137df2fa9b40f5436a4e1df21
Author: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>
Date:   Wed Jul 6 20:27:41 2016 +1200

Bug 1599404: Better handling of wwwroot with no trailing slash

behatnotneeded: Hard to test with Behat. I've provided a phpunit
test instead.

Change-Id: Ie2cde2501a69db652f8fcefd8e622166492f824e

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1599404

Title:
  The function "get_mahara_install_subdirectory" doesn't correctly
  handle a URL with a missing trailing slash

Status in Mahara:
  Fix Committed

Bug description:
  One of the causes of Bug 1592236 was that
  get_mahara_install_subdirectory() doesn't correctly handle a wwwroot
  with a missing trailing slash. If you set your wwwroot to e.g.
  "http://www.example.com";, it will return "www.example.com".

  This rarely affects anything because fairly early in init.php we
  rectify $CFG->wwwroot to add the missing trailing slash if it's
  missing. But if we need to call it before that point it can cause
  subtle problems, so we may as well fix it.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1599404/+subscriptions