mahara-contributors team mailing list archive

[Mahara Bot <1599305@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/6683
Committed: https://git.mahara.org/mahara/mahara/commit/36cf8e7231caa3bc643f1ade89d48fd1c8115b66
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    16.04_STABLE

commit 36cf8e7231caa3bc643f1ade89d48fd1c8115b66
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Wed Jul 6 10:04:37 2016 +1200

Bug 1599305: Set users 'grouproles' to only contain undeleted groups

And also update the current user's group roles on group deletion

behatnotneeded

Change-Id: Id32ea6b0ba95a4057c1a84e860aa2ded3879f8b0
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit 8b93bf616a93666af32bafe36be1470802c0236e)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1599305

Title:
   $USER->get('grouproles') returning values for deleted groups

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed

Bug description:
  To test:

  1) Have a Mahara site with production mode set to off

  2) Create a new user and login as that user

  3) Create a group then delete the group

  4) Create a page and add an image block to the page

  5) Select the 'group files' tab  - there should be nothing to select

  6) Click the 'remove' link for the configuration form

  7) Navigate away and you should see these errors:

  [WAR] 33 (lib/form/elements/filebrowser.php:380) Undefined offset: 0
  [WAR] 33 (lib/form/elements/filebrowser.php:380) Trying to get property of non-object

  The reason for this is the $USER->get('grouproles') still holds the
  role to the deleted group even if you log out and back in again.

  We should only populate the grouproles with roles to non-deleted
  groups.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1599305/+subscriptions