← Back to team overview

mahara-contributors team mailing list archive

[Bug 1592213] Re: Render issue with Masonry on Skins page

 

** Changed in: mahara/16.04
       Status: Fix Committed => Fix Released

** Changed in: mahara/15.10
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1592213

Title:
  Render issue with Masonry on Skins page

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Released
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  On the page skin/index.php, when you create more than 3 skins, masonry
  fails to calculate the content and positions a skin box in the wrong
  position.

  This always happens on page load when the function initUserThumbnailsMasonry() fires (theme.js).
  From what i can see, when the function is called, content is not loaded, therefore creating a wrong dimension. Not 100% sure but if you follow the steps bellow maybe it will help determine the cause.

  1. go to /skins/index.php.
  2. create 4 new skin. Skin boxes will all align correctly.
  3. Refresh the browser.
  4. Notice the 4th skin box absolute positioning is incorrect and overlaps box 3.
  5. Open up browser developer tools, navigate to view the raw js "theme.js".
  6. Scroll to line 129 and add a break-point and refresh the browser.
  7. Click through the break-point and the Skins will load correctly.
  or
  7. Click on a navigation link to open a new page eg "Shared with me" then go page to skins page via the link.
  8. If you have the break-point set on the js, it will load correctly. If not, it will break.

  I have tested this a bit and it doesn't always work :) Sometime if you
  refresh the page, it works. Other times it doesn't.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1592213/+subscriptions


References