mahara-contributors team mailing list archive

[Aaron Wells <1560131@xxxxxxxxxxxxxxxxxx>]

The first patch for Bug 1579285 wound up re-implementing the same
things, so this patch is no longer needed for the master (16.10) branch.

The earlier branches are still affected, which is to say they're
incompatible with SimpleSAMLPHP 1.14.x. But I think the code change is
not backwards-compatible with older SimpleSAMLPHP versions, so that
makes it too risky to include in a minor version release because it
might break someone's existing setup.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1560131

Title:
  Mahara SAML auth broken with Simplesamlphp 1.14.x

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Won't Fix
Status in Mahara 15.10 series:
  Won't Fix
Status in Mahara 16.04 series:
  Won't Fix
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  When attempting to use Mahara 15.10.1 on Ubuntu 14.04.4 with
  Simplesamlphp 1.14.x, I attempt to SSO login and get the error:

  PHP Fatal error:  Call to undefined method
  SimpleSAML_Session::getInstance() in
  /cluster/www/sites/secure.smus.ca/www/mahara/auth/saml/index.php on
  line 56

  This appears to be because the Simplesamlphp people removed the
  function call SimpleSAML_Session::getInstance() in version 1.14.0:

  https://simplesamlphp.org/docs/stable/simplesamlphp-upgrade-notes-1.14

  I looked at auth/saml/index.php and it doesn't look like there are too
  many times that $saml_session is used.  I'll see if I can figure out
  what to use in place of the $saml_session stuff.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1560131/+subscriptions