mahara-contributors team mailing list archive

[Mahara Bot <1603332@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/6726
Committed: https://git.mahara.org/mahara/mahara/commit/d48ab030e9bb983d1dfeb869c47d5463345b6b3d
Submitter: Son Nguyen (son.nguyen@xxxxxxxxxxxxxxx)
Branch:    master

commit d48ab030e9bb983d1dfeb869c47d5463345b6b3d
Author: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>
Date:   Fri Jul 15 19:28:20 2016 +1200

Bug 1603332: Better default styling for plugin config page

Change-Id: I07bb4031679fec26ea0535dc9b6604b5d1c42bc8
behatnotneeded: Covered by existing tests

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1603332

Title:
  Make default plugin config styling be "panel panel-body"

Status in Mahara:
  Fix Committed

Bug description:
  The plugin config page's page template is basically just this:

  {include header.tpl}
  {$form|safe}
  {include footer.tpl}

  In order for the displayed form to look good, it needs to either be in
  class "panel panel-body", or be made of collapsible fieldsets. All of
  the core plugins are either made of collapsible fieldsets, or have
  "class=panel panel-body" declared at the plugin level, in the
  "get_config_options()" function for each one.

  But third-party plugin developers would have to know to add those two
  classes. Otherwise, the form is displayed directly on top of the page
  background, instead of in a white panel on top of the page background.

  So what we ought to do, is make "panel panel-body" be the default
  class for the plugin configuration page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1603332/+subscriptions