mahara-contributors team mailing list archive

[Aaron Wells <1606094@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

On the institution config screen, there's a setting called "Update user
quotas" that will do a one-time application of the institution's current
"default quota" value to all existing users of the institution. At the
same time, if you're using the "quota almost exceeded" notification
emails, it will check each user whose quota has just been changed and
send them a notification if they're near the threshold.

The first part of this works fine. It does indeed update the quota for
members of the changed institution, and nobody else. But there's a bug
in the second part, that sends out the notifications. Instead of only
checking the users in the institution, it checks *every* user in the
site, and sends a notification to any of them who are near the threshold
for the changed institution. This is not only annoying to users who
aren't in the institution, but also confusing, because the email will
tell them that their quota is the size of the changed institution's
quota, when in fact their quota has not changed.

To replicate:

1. Clean Mahara install
2. Log in as admin
3. Upload a 1MB file into your File -> Contents area
4. Create an institution. Save the institution.
5. Click the "edit" link for the institution.
6. Set "Default quota" to 100 Kilobytes.
7. Set "Update user quotas" to "On"
8. Click "Submit"

Expected result: The admin user should not receive a notification,
because they're not in that institution and their quota has not changed.

Actual result: The admin user receives a notification about being over
their quota, but their quota has not actually changed from the default
50MB.

** Affects: mahara
     Importance: High
     Assignee: Aaron Wells (u-aaronw)
         Status: In Progress

** Affects: mahara/15.04
     Importance: High
     Assignee: Aaron Wells (u-aaronw)
         Status: In Progress

** Affects: mahara/15.10
     Importance: High
     Assignee: Aaron Wells (u-aaronw)
         Status: In Progress

** Affects: mahara/16.04
     Importance: High
     Assignee: Aaron Wells (u-aaronw)
         Status: In Progress

** Affects: mahara/16.10
     Importance: High
     Assignee: Aaron Wells (u-aaronw)
         Status: In Progress

** Also affects: mahara/15.10
   Importance: Undecided
       Status: New

** Also affects: mahara/15.04
   Importance: Undecided
       Status: New

** Also affects: mahara/16.10
   Importance: Undecided
       Status: New

** Also affects: mahara/16.04
   Importance: Undecided
       Status: New

** Changed in: mahara/15.04
       Status: New => In Progress

** Changed in: mahara/15.10
       Status: New => In Progress

** Changed in: mahara/16.04
       Status: New => In Progress

** Changed in: mahara/16.10
       Status: New => In Progress

** Changed in: mahara/15.04
   Importance: Undecided => High

** Changed in: mahara/15.10
   Importance: Undecided => High

** Changed in: mahara/16.04
   Importance: Undecided => High

** Changed in: mahara/16.10
   Importance: Undecided => High

** Changed in: mahara/15.04
     Assignee: (unassigned) => Aaron Wells (u-aaronw)

** Changed in: mahara/15.10
     Assignee: (unassigned) => Aaron Wells (u-aaronw)

** Changed in: mahara/16.04
     Assignee: (unassigned) => Aaron Wells (u-aaronw)

** Changed in: mahara/16.10
     Assignee: (unassigned) => Aaron Wells (u-aaronw)

** Changed in: mahara/16.10
    Milestone: None => 16.10.0

** Changed in: mahara/16.04
    Milestone: None => 16.04.3

** Changed in: mahara/15.10
    Milestone: None => 15.10.5

** Changed in: mahara/15.04
    Milestone: None => 15.04.9

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1606094

Title:
  Changing the file quota for users in an institution, can send
  notifications to users in other institutions

Status in Mahara:
  In Progress
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  In Progress

Bug description:
  On the institution config screen, there's a setting called "Update
  user quotas" that will do a one-time application of the institution's
  current "default quota" value to all existing users of the
  institution. At the same time, if you're using the "quota almost
  exceeded" notification emails, it will check each user whose quota has
  just been changed and send them a notification if they're near the
  threshold.

  The first part of this works fine. It does indeed update the quota for
  members of the changed institution, and nobody else. But there's a bug
  in the second part, that sends out the notifications. Instead of only
  checking the users in the institution, it checks *every* user in the
  site, and sends a notification to any of them who are near the
  threshold for the changed institution. This is not only annoying to
  users who aren't in the institution, but also confusing, because the
  email will tell them that their quota is the size of the changed
  institution's quota, when in fact their quota has not changed.

  To replicate:

  1. Clean Mahara install
  2. Log in as admin
  3. Upload a 1MB file into your File -> Contents area
  4. Create an institution. Save the institution.
  5. Click the "edit" link for the institution.
  6. Set "Default quota" to 100 Kilobytes.
  7. Set "Update user quotas" to "On"
  8. Click "Submit"

  Expected result: The admin user should not receive a notification,
  because they're not in that institution and their quota has not
  changed.

  Actual result: The admin user receives a notification about being over
  their quota, but their quota has not actually changed from the default
  50MB.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1606094/+subscriptions