← Back to team overview

mahara-contributors team mailing list archive

[Bug 1605127] Re: Mismatched function declaration, urdate_url() in lib/activity.php

 

Hi Kristina & Howard,

You can test out that patch by doing this:

1. Send a friend request (so that ActivityType::update_url() gets run)
2. Send a user a private message (so that ActivityTypeMultirecipientnotification::update_url() gets run)

Just test that both notifications go through successfully, that any
links in the message or the emails are correct, and that there aren't
any error messages in the logs.

Cheers,
Aaron

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1605127

Title:
  Mismatched function declaration, urdate_url() in lib/activity.php

Status in Mahara:
  In Progress
Status in Mahara 15.04 series:
  In Progress
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  In Progress

Bug description:
  Branch 16.04

  In lib/activity.php at approx line 710 the function update_url() is
  declared. It has no parameters.

  However, at approx line 750 it is called and a parameter
  ($userdata->internalid) is used. One of them must be wrong, surely?

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1605127/+subscriptions


References