mahara-contributors team mailing list archive

[Mahara Bot <1606435@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/6779
Committed: https://git.mahara.org/mahara/mahara/commit/8e97a2422225c24b500089c2a8ce79bbe62c65d6
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    15.10_STABLE

commit 8e97a2422225c24b500089c2a8ce79bbe62c65d6
Author: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>
Date:   Tue Jul 26 17:28:29 2016 +1200

Bug 1606435: Too few parameters sent to lang string

Change-Id: I69d51c750fbcf605f98a5825fc8af1113719b723
behatnotneeded: Test to come later
(cherry picked from commit f4ed391a7581d6556dfd46c2bcb5831d1d5e700e)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1606435

Title:
  Not sending enough parameters to "useroverquotathreshold" lang string

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  The lang string "useroverquotathreshold" in artefact.file.php expects
  three sprintf parameters, but in the two places we use it, we only use
  one parameter. As a result, it prints a warning message to the error
  logs, and the string it should print is replaced with an empty string.

  Here's the warning message:

   [WAR] 37 (lib/mahara.php:1418) sprintf(): Too few arguments
   Call stack (most recent first):
     * log_message("sprintf(): Too few arguments", 8, true, true, "/home/aaronw/www/mahara/htdocs/lib/mahara.php", 1418) at /home/aaronw/www/mahara/htdocs/lib/errors.php:489
     * error(2, "sprintf(): Too few arguments", "/home/aaronw/www/mahara/htdocs/lib/mahara.php", 1418, array(size 3)) at Unknown:0
     * sprintf("User %s has arrived at %s%% percent of their %s qu...", "user1 user1 (user1)") at Unknown:0
     * call_user_func_array("sprintf", array(size 2)) at /home/aaronw/www/mahara/htdocs/lib/mahara.php:1418
     * format_langstring("User %s has arrived at %s%% percent of their %s qu...", array(size 1), "en.utf8") at /home/aaronw/www/mahara/htdocs/lib/mahara.php:505
     * get_string_location("useroverquotathreshold", "artefact.file", array(size 1)) at /home/aaronw/www/mahara/htdocs/lib/mahara.php:294
     * get_string("useroverquotathreshold", "artefact.file", "user1 user1 (user1)") at /home/aaronw/www/mahara/htdocs/admin/users/edit.php:405
     * edituser_site_submit(object(Pieform), array(size 16)) at Unknown:0
     * call_user_func_array("edituser_site_submit", array(size 2)) at /home/aaronw/www/mahara/htdocs/lib/pieforms/pieform.php:540
     * Pieform->__construct(array(size 6)) at /home/aaronw/www/mahara/htdocs/lib/pieforms/pieform.php:161
     * Pieform::process(array(size 6)) at /home/aaronw/www/mahara/htdocs/lib/mahara.php:4730
     * pieform(array(size 6)) at /home/aaronw/www/mahara/htdocs/admin/users/edit.php:265

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1606435/+subscriptions