mahara-contributors team mailing list archive

[Mahara Bot <1602447@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/6716
Committed: https://git.mahara.org/mahara/mahara/commit/08facc98eca2c8c5c9171099bc717278a45b4518
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 08facc98eca2c8c5c9171099bc717278a45b4518
Author: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>
Date:   Wed Jul 13 11:35:34 2016 +1200

Bug 1602447: Allow ">" in CSS stylesheets

(Also removing the HTMLPurifier custom filters while I'm at it,
because they don't actually do anything in this context.)

behatnotneeded: Behat test to come later (due to current
Firefox/Selenium incompatibility issues.)

Change-Id: I47d3fba1962ff03b74e2b721ead81f1530886f04

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1602447

Title:
  Can't use ">" CSS selector in skins

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  See https://mahara.org/interaction/forum/topic.php?id=7659

  The ">" character is a basic selector in CSS, which allows you to
  specify an element contained within another element. For example,
  "div.class1 > span.class2" would match the span in

  <div class="class1">Don't style me. But <span class="class2">style
  me!</span></div>

  If you try to use a ">" in the "Custom CSS" section of a Mahara skin,
  it gets turned into "\3E". Probably it's being accidentally over-
  escaped at some point, because ">" is a syntactically important
  character in HTML.

  To replicate:

  1. Create a Mahara skin
  2. On the skin editor go to the "Advanced" tab
  3. In "Custom CSS" enter this:

  body > .main-content > .row {
  background-color: red;
  }

  4. Click "Save" (this closes the skin editor)
  5. Edit the skin again, and navigate back to the Advanced tab.

  Expected result: The "Custom CSS" field shows what you entered before
  Actual result: The ">" in the Custom CSS field has been turned into "\3E".

  Further test:

  1. Apply the skin you selected in the previous test, to a Mahara page.
  2. View the page in display mode.

  Expected result: The page background is red.
  Actual result: No change in the the appearance of the page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1602447/+subscriptions