mahara-contributors team mailing list archive

[Mahara Bot <1595364@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/6823
Committed: https://git.mahara.org/mahara/mahara/commit/5f4bcab33ed02896d656e1ddc566a0cb200ff883
Submitter: Aaron Wells (aaronw@xxxxxxxxxxxxxxx)
Branch:    15.10_STABLE

commit 5f4bcab33ed02896d656e1ddc566a0cb200ff883
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Thu Jun 23 13:41:09 2016 +1200

Bug 1595364: removing the correct row in js

Rather than relying on loop

Change-Id: I4ff09cdd056cedb927a26fa6c0ba33ccb83d5ebc
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit bcfc376633246f4b0c29b5c6b1acca493ee51f04)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1595364

Title:
  Unable to remove first auth method via institution edit

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  There is a bug in the code that stops one from removing the first
  option from auth methods for an institution

  This is due to the way we are using jQuery.remove()

  Get the console error:

  TypeError: elem is null
  while ((child = elem.firstChild)) {

  Due to: instances.remove(i)

  when i = 1 or above it removes the row relating to the count before
  rebuilding the rows but when i = 0 it removes all the rows and so
  nothing to rebuild

  Will fix this up so it actually removes the row relating to the id

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1595364/+subscriptions