mahara-contributors team mailing list archive
-
mahara-contributors team
-
Mailing list archive
-
Message #37102
[Bug 1611995] A change has been merged
Reviewed: https://reviews.mahara.org/6826
Committed: https://git.mahara.org/mahara/mahara/commit/da531e94e7f885b2689fb1b4fdb8c92d79d7e7b9
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch: 16.04_STABLE
commit da531e94e7f885b2689fb1b4fdb8c92d79d7e7b9
Author: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>
Date: Thu Aug 11 11:43:18 2016 +1200
Bug 1611995: Remove redundant file
This file was accidentally left in place when profileicons
were moved from internal artefacts to file artefacts. It's
now redundant with artefact/file/profileicons.json.php
Change-Id: I544cda768e636a0076595ed64f49425fe1607e41
behatnotneeded: Covered by existing tests
(cherry picked from commit 9d7a9302a3b8032540f1594bf9f4bfe50d1edfdd)
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1611995
Title:
Delete redundant profileicons.json.php file
Status in Mahara:
Fix Committed
Status in Mahara 15.04 series:
Fix Committed
Status in Mahara 15.10 series:
Fix Committed
Status in Mahara 16.04 series:
Fix Committed
Status in Mahara 16.10 series:
Fix Committed
Bug description:
While code reviewing Bug 1590632, I noticed that there are two files
named "profileicons.json.php" in the Mahara code base:
htdocs/artefact/file/profileicons.json.php
htdocs/artefact/internal/profileicons.json.php
It looks like only the one under the "file" artefact is actually used
(it's referenced in htdocs/artefact/file/profileicons.php). The other
one was mistakenly left behind in commit
c2356895f72ff2d9b7130084fc403ad1cd20d59a, when the profileicons were
moved from being internal artefacts to file artefacts.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1611995/+subscriptions
References