mahara-contributors team mailing list archive

[Mahara Bot <1611547@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/6825
Committed: https://git.mahara.org/mahara/mahara/commit/4e585756de5e3145615ee54749b673450e27bf22
Submitter: Aaron Wells (aaronw@xxxxxxxxxxxxxxx)
Branch:    master

commit 4e585756de5e3145615ee54749b673450e27bf22
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Thu Aug 11 20:56:11 2016 +1200

Bug 1611547: Problem with userlist forms

The forms are not rendering correctly now that we have removed
mochikit from mahara.js

The problem is the typeof(message) check can return 'object' when the
message is null - see http://www.ecma-international.org/ecma-262/5.1/#sec-11.4.3

So need to avoid trying to get the sub message from null object

Also added some accessibility strings to the Institutions -> Members
add form

Change-Id: Ic0a02ef35d5d0ed1844ab5792542fe0872e5376f
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1611547

Title:
  Adding members via Institutions -> members is broken

Status in Mahara:
  Fix Committed

Bug description:
  Turns out the patch 83069d9effc9707cf3aa1f72c8e7de8ecd78e6a4 (Purge
  MochiKit from mahara.js) broke the ability to add members to an
  institution via Institution -> Members

  The js returns a TypeError: data is null

  I suspect that all the pages using the double textarea box setup will
  be broken

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1611547/+subscriptions