← Back to team overview

mahara-contributors team mailing list archive

[Bug 1457709] A change has been merged

 

Reviewed:  https://reviews.mahara.org/6847
Committed: https://git.mahara.org/mahara/mahara/commit/3c7e24e7defe3c3d1a8ec59026d8d05e0cd026b8
Submitter: Aaron Wells (aaronw@xxxxxxxxxxxxxxx)
Branch:    master

commit 3c7e24e7defe3c3d1a8ec59026d8d05e0cd026b8
Author: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>
Date:   Thu May 21 14:36:32 2015 +1200

elasticsearch: Add index name to _bulk command path

Bug 1457709: We only do this when the command comes
from an Index object itself, which means that all the
data in the bulk request will have the same index anyway.

You'll still need to set rest.action.multi.allow_explicit_index:false
in your config.yml, or else the data will be able to override the
index name in the URL.

See https://www.elastic.co/guide/en/elasticsearch/reference/current/url-
access-control.html

Conflicts:
	htdocs/lib/elastica/README.Mahara
	htdocs/lib/elastica/lib/Elastica/Client.php

behatnotneeded: Can't be tested in behat

Change-Id: Ide22a0026aeb480a130e39c3ea2f327ef2de167f

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1457709

Title:
  Elasticsearch plugin doesn't work with URL-based access control

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Released

Bug description:
  We changed the Elasticsearch plugin to use the _bulk command to load
  data into Elasticsearch. But this poses problems for hosting setups
  that are using URL-based access control, as described here:
  https://www.elastic.co/guide/en/elasticsearch/reference/1.x/url-
  access-control.html

  This is because the way Elastica handles the _bulk command, it puts
  the index name into the request body: localhost/_bulk, instead of
  localhost/index/_bulk

  Elasticsearch *can* handle the indexname in the URL for _bulk
  commands. But we'll need to patch Elastica to handle it.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1457709/+subscriptions


References