mahara-contributors team mailing list archive
-
mahara-contributors team
-
Mailing list archive
-
Message #37230
[Bug 1369830] A change has been merged
Reviewed: https://reviews.mahara.org/6852
Committed: https://git.mahara.org/mahara/mahara/commit/a485b22c302f862e1bfd4254320a837418c24511
Submitter: Aaron Wells (aaronw@xxxxxxxxxxxxxxx)
Branch: master
commit a485b22c302f862e1bfd4254320a837418c24511
Author: Son Nguyen <son.nguyen@xxxxxxxxxxxxxxx>
Date: Wed Sep 24 16:01:14 2014 +1200
Allow CSS comments in customised skins. Bug 1369830
As we add a new configuration option to HTML Purifier,
we have to update HTMLPurifier/ConfigSchema/schema.ser
1. Download and unzip HTMLPurifier package
2. Copy Filter.ExtractStyleBlocks.PreserveCSS.txt
from mahara to the unzip folder
3. Run php maintenance/generate-schema-cache.php in
unzup folder
4. Copy over lib/HTMLPurifier/ConfigSchema/schema.ser
from unzip folder to mahara
Change-Id: Id955dec7d2cf795a485ac220c3ea50052d4de47f
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1369830
Title:
Comments in CSS disappear in page skins Custom CSS
Status in Mahara:
Fix Released
Bug description:
Originally reported on the Mahara forum:
https://mahara.org/interaction/forum/topic.php?id=6443&offset=0&limit=10
This is more of a feature request.
We are currently on 1.9.2 on Linux w/ MySQL.
The issue is that when creating a page skin, comments in the CSS disappear from page skins Custom CSS area.
Is there a way of getting the comments to stay?
It is quite important that people can comment what their CSS affects - so if they make their skin available to others, other people can then know what to change, and how it will affect the style of their page skin.
For example:
/* This makes the page heading background transparent*/
#top-wrapper {
background: transparent;
}
/* This makes the page footer background transparent*/
#footer-wrap {
background-color: transparent;
}
#footer {
background-color: transparent;
}
/* This will change the colour of the tabbed navigation in a collection*/
ul.colnav li a, ul.colnav li a:link, ul.colnav li a:visited, ul.colnav li a:active {
background:#A2F7FF;
color:#9F0DF6
}
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1369830/+subscriptions
References