mahara-contributors team mailing list archive

[Mahara Bot <1534383@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/5911
Committed: https://git.mahara.org/mahara/mahara/commit/a618448e03978f58a7d3795e85b3a8f5b57bd54f
Submitter: Son Nguyen (son.nguyen@xxxxxxxxxxxxxxx)
Branch:    master

commit a618448e03978f58a7d3795e85b3a8f5b57bd54f
Author: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>
Date:   Fri Jan 15 13:10:21 2016 +1300

Bug 1534383 Refactoring BlockInstance::bulk_delete_artefacts()

Renaming to make it less misleading, making its parameters
simpler, and adding some comments to explain how it works

behatnotneeded: Covered by existing tests that delete artefacts

Change-Id: I6091dd4f9cae541a01ddff315629066e0c9df1fb

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1534383

Title:
  Refactor BlockInstance::bulk_delete_artefacts($records)

Status in Mahara:
  In Progress

Bug description:
  See
  https://mahara.org/interaction/forum/topic.php?id=7465&offset=0&limit=10#post30151.
  This method is old and has some problems that make it confusing. It'd
  be nice to clean it up a little. In particular, it has a misleading
  name (it doesn't delete artefacts; it only de-selects them from block
  instances). And it has a very particular parameter format that is
  tightly coupled to a particular SQL query, which could easily be moved
  inside the function in order to make its API more understandable.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1534383/+subscriptions