mahara-contributors team mailing list archive

[Mahara Bot <1544381@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/6898
Committed: https://git.mahara.org/mahara/mahara/commit/ffa2b74d77f96ad20da3fa88387f99862a84a317
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    15.10_STABLE

commit ffa2b74d77f96ad20da3fa88387f99862a84a317
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Mon Feb 15 15:48:00 2016 +1300

Bug 1544381: Need to move get_homepage_url() out of template

Because if we have a latest pages block but no group pages listed then
the template will not initially compile as there has been no call to
require lib/group.php

Actually we should avoid having non basic function calls in the template
so I'll move all instances of group_homepage_url() in templates out
to the php that generates the data.

behatnotneeded

Change-Id: Ia804fee854418e7b3b3620c998f2219a0b0d6f25
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1544381

Title:
  "New views" block crashes after clearing Dwoo cache

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Released
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  Sometimes when I'm testing things on my cleanurl https:// site I get
  this strange error where if I go to the homepage it tries to reload
  the page over and over.

  In the error logs I see:

  [WAR] b6 (lib/dwoo/dwoo/Dwoo/Loader.php:119) Plugin <em>group_homepage_url</em> can not be found, maybe you forgot to bind it if it's a custom plugin ?, referer: https://mahara-testing/
  Call stack (most recent first):, referer: https://mahara-testing/
     * Dwoo_Loader->loadPlugin("group_homepage_url", true) at /home/robertl/htdocs/mahara-testing/mahara/htdocs/lib/dwoo/dwoo/Dwoo/Compiler.php:2968, referer: https://mahara-testing/
     * Dwoo_Compiler->getPluginType("group_homepage_url") at /home/robertl/htdocs/mahara-testing/mahara/htdocs/lib/dwoo/dwoo/Dwoo/Compiler.php:1715, referer: https://mahara-testing/
     * Dwoo_Compiler->parseFunction("{if $views}, referer: https://mahara-testing/
   <div class="list-group">, referer: https://mahara-testing/
       {foreach ...", 500, 1902, false, "root", 535) at /home/robertl/htdocs/mahara-testing/mahara/htdocs/lib/dwoo/dwoo/Dwoo/Compiler.php:1365, referer: https://mahara-testing/
     * Dwoo_Compiler->parse("{if $views}, referer: https://mahara-testing/
   <div class="list-group">, referer: https://mahara-testing/
       {foreach ...", 500, null, false, "root", 535) at /home/robertl/htdocs/mahara-testing/mahara/htdocs/lib/dwoo/dwoo/Dwoo/Compiler.php:805, referer: https://mahara-testing/
     * Dwoo_Compiler->compile(object(Dwoo_Mahara), object(Dwoo_Template_Mahara)) at /home/robertl/htdocs/mahara-testing/mahara/htdocs/lib/dwoo/dwoo/Dwoo/Template/String.php:370, referer: https://mahara-testing/
     * Dwoo_Template_String->getCompiledTemplate(object(Dwoo_Mahara), null) at /home/robertl/htdocs/mahara-testing/mahara/htdocs/lib/dwoo/dwoo/Dwoo/Core.php:373, referer: https://mahara-testing/
     * Dwoo_Core->get(object(Dwoo_Template_Mahara), array(size 5)) at /home/robertl/htdocs/mahara-testing/mahara/htdocs/lib/dwoo/mahara/Dwoo_Mahara.php:123, referer: https://mahara-testing/
     * Dwoo_Mahara->fetch("blocktype:newviews:newviews.tpl") at /home/robertl/htdocs/mahara-testing/mahara/htdocs/blocktype/newviews/lib.php:59, referer: https://mahara-testing/
     * PluginBlocktypeNewViews::render_instance(object(BlockInstance)) at Unknown:0, referer: https://mahara-testing/

  
  If I make a dwoo plugin for group_homepage_url() the issue goes away

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1544381/+subscriptions