mahara-contributors team mailing list archive
-
mahara-contributors team
-
Mailing list archive
-
Message #37451
[Bug 1620119] Re: Annotation feedback deit/delete buttons not styled correctly
I've marked this bug as 'high' because it would be good to fix this asap
as part of 16.10rc2
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1620119
Title:
Annotation feedback deit/delete buttons not styled correctly
Status in Mahara:
Confirmed
Bug description:
When comparing the edit/delete buttons on annotation feedback they are
different to the same set of buttons on comments, when comments are a
block on the page rather than at foot of the page.
See attached screenshot
The issues I see are:
1) The first annotation feedback's edit button is floating in space
rather than being anchored to a line
2) When we have both edit and delete buttons they are not horizontally
next to each other.
Also another issue is an admin can't delete their own feedback from
their own page's annotation block.
In artefact/annotation/lib.php there is the following code:
else if (($candelete || $item->isauthor) && !$is_export_preview && !$isadminfeedback) {
// If the auther was admin/staff and not the owner of the annotation,
// the feedback can't be deleted.
But it is not correct when the owner is also an administrator.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1620119/+subscriptions
References