mahara-contributors team mailing list archive

[Robert Lyon <robertl@xxxxxxxxxxxxxxx>]

When we have this situation:

1) an older site - say 16.04
2) annotation block enabled/active in Admmin -> Extensions
3) add some annotation blocks to a page
4) leave feedback on annotation blocks

And we upgrade to master and then do:

1) install/activate smartevidence
2) allow smart evidence to the institution the above user/page is in
3) add the page into a collection and choose a smart evidence framework for it

When we go to view the page we get 'property of non-object' errors

This is because the code expected all annotations to have an evidence
level set

I've added check for this now

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1623282

Title:
  Existing annotations throw warning due to missing evidence

Status in Mahara:
  In Progress

Bug description:
  As we added annotation plugin a while back those annotations do not
  have an evidence value set for them.

  We need to take that into account when rendering their feedback

  Call stack (most recent first):

      log_message("Trying to get property of non-object", 8, true, true, "/var/www/html/mahara/htdocs/artefact/annotation/li...", 1278) at /var/www/html/mahara/htdocs/lib/errors.php:513
      error(8, "Trying to get property of non-object", "/var/www/html/mahara/htdocs/artefact/annotation/li...", 1278, array(size 11)) at /var/www/html/mahara/htdocs/artefact/annotation/lib.php:1278
      ArtefactTypeAnnotationfeedback::add_annotation_feedback_form(object(ArtefactTypeAnnotation), object(View), null, "108", false, "0") at /var/www/html/mahara/htdocs/artefact/annotation/lib.php:1132

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1623282/+subscriptions