← Back to team overview

mahara-contributors team mailing list archive

[Bug 1567187] A change has been merged

 

Reviewed:  https://reviews.mahara.org/6979
Committed: https://git.mahara.org/mahara/mahara/commit/b5683b8a566ebf6c649a99f440d17c8dd88548aa
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    16.10_STABLE

commit b5683b8a566ebf6c649a99f440d17c8dd88548aa
Author: Cecilia Vela Gurovic <cecilia@xxxxxxxxxxxxxxx>
Date:   Tue Sep 13 13:29:58 2016 +1200

Bug 1567187: Added correct screenreader tags
in select/edit buttons for folder and files

behatnotneeded

Change-Id: Icf89b2add901828470dff50fb18cc39ef2f31056
(cherry picked from commit 28ee13502f2e924eedabc262b45d4fdb274d67c6)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1567187

Title:
  "Select" and "Edit" buttons don't have screenreader text

Status in Mahara:
  Fix Committed

Bug description:
  Mahara 16.04 (probably also 15.10 for the "Edit" button)

  In patch https://reviews.mahara.org/6307 we are adding a "Select"
  button to the file browser when in a block. During the testing of the
  patch I noticed that the screenreader tag only displayed "Select" or
  nothing at all for the "Edit" button.

  When we look at the buttons in the regular file browser, the
  screenreader text says for example 'Edit folder "folder"'. However,
  that code is not rendered in the file browser when in a block modal
  for the "Edit" button. It's currently not there for the "Select"
  button because the previous input method didn't work.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1567187/+subscriptions


References