mahara-contributors team mailing list archive

[Mahara Bot <1526073@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/5850
Committed: https://git.mahara.org/mahara/mahara/commit/a79dd6bbeaee8f62ebeab6dfd697089cbfa1e1ca
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit a79dd6bbeaee8f62ebeab6dfd697089cbfa1e1ca
Author: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>
Date:   Tue Dec 15 13:17:34 2015 +1300

Get rid of redundant DB writes in set_config()

Bug 1526073. Also in set_config_plugin() and
set_config_plugin_instance().

set_config_institution() is more complicated, and outside
the scope of this bug.

Change-Id: Ibaeb93fea83c190e6ffab7cd000eddf98f3afbb7
behatnotneeded: Covered by existing tests

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1526073

Title:
  set_config() writes to the database even if it's not necessary

Status in Mahara:
  Fix Committed

Bug description:
  Mahara's set_config() methods updates the database every single time
  you call it, even if you haven't actually changed the value of the
  field.

  It would be more efficient if it did not do this. Especially since it
  already does a SELECT statement to check whether it needs to do an
  UPDATE or INSERT, it would be trivial to also make it check to see if
  the value in the database is the same as the value passed by the user,
  and skip that UPDATE if so.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1526073/+subscriptions