← Back to team overview

mahara-contributors team mailing list archive

[Bug 1626281] A patch has been submitted for review

 

Patch for "master" branch: https://reviews.mahara.org/6995

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1626281

Title:
  Allow the js lang strings to have their section set when doing
  variable replacement

Status in Mahara:
  In Progress

Bug description:
  Currently when we have a js string, say string.nrrows='%s rows' and we
  call it with get_string('nrrows', 4) - but we should call it with
  get_string('nrrows', 'view', 4) to indicate that this string is from
  the 'view' lang file.

  I'll make the change so that the 'section' can be passed in as well so
  that in the future we can decide which section's lang string to use
  rather than currently having them be all unique.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1626281/+subscriptions


References