mahara-contributors team mailing list archive

[Mahara Bot <1624153@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/7024
Committed: https://git.mahara.org/mahara/mahara/commit/7727dd6260f9fac34a5a6e7306a80b3864df820c
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    16.10_STABLE

commit 7727dd6260f9fac34a5a6e7306a80b3864df820c
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Sat Sep 17 13:54:50 2016 +1200

Bug 1624153: Better url checking for resume book form

This fix deals with a better checking of the supplied url and making
sure it is validated on both the addbook form and editcomposite form

Also fixing the help message issues when on editcomposite.php page

behatnotneeded - existing tests should be ok

Change-Id: I8d9e26dcf71f6bc2b3953a5548c3426efb2d459b
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit 6cf961724370d47e2ebe751e6e8bb7881f0ea8cd)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1624153

Title:
  Valid URL(www) is not accepted while saving Books and publications

Status in Mahara:
  Fix Committed

Bug description:
  Tested in

  Version 16.04 & Version 16.10

  Theme: Ocean and default

  Browser: FF, chrome

  Steps to Reproduce:

  1) Navigate to Content>Reseme>Achievements
  2) Click on add under Books and Publications
  3) Enter the mandatory fields and also add a valid URL ( I have used www.facebook.com)
  4) Click on save

  Expected result: The page should be saved
  Actual Result: Bug one: An error message is displayed " Not a Valid URL"

  Note: When www is replaced with http or https the page is saved
  successfully. And when we re-edit the URL back to www it accepts it

  Bug two: After saving the page try to re-edit  and click on any of the
  help icon, it doesn't show the information and instead it displays an
  error message ( see attached )

  Note: Similarly help icon doesn't show the information on "
  professional memberships " too

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1624153/+subscriptions