mahara-contributors team mailing list archive

[Robert Lyon <robertl@xxxxxxxxxxxxxxx>]

Currently when one copies their own collection that contains a SE
framework it copies the blocks on the page but refers them to the the
same artefact as before.

So if they update the annotation on the new collection's page it updates
the text in both places (like a notes block)

This is not what we want.

What we want is:

1) copying a collection with smart evidence it makes a copy of the annotation artefacts
2) but does not make a copy of the annotationfeedback artefacts
3) If the user is copying the collection to themselves they get a copy of the framework_evidence rows matching the new view/artefact/block values but no assessment/review set


** Changed in: mahara
       Status: Confirmed => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1629144

Title:
  Problems with copying a SmartEvidence collection with annotations

Status in Mahara:
  In Progress

Bug description:
  Mahara 16.10dev

  1. Set up a SmartEvidence collection.
  2. Put a couple of annotations on the page.
  3. Add a couple of feedbacks to the annotations.
  4. Copy the collection in the same user account.
  5. Open a page that has an annotation.

  I get the following error message multiple times:

  [WAR] 5f (artefact/annotation/lib.php:1294) Trying to get property of non-object
  Call stack (most recent first):

      log_message("Trying to get property of non-object", 8, true, true, "/home/kristina/code/1610stable/htdocs/artefact/ann...", 1294) at /home/kristina/code/1610stable/htdocs/lib/errors.php:513
      error(8, "Trying to get property of non-object", "/home/kristina/code/1610stable/htdocs/artefact/ann...", 1294, array(size 13)) at /home/kristina/code/1610stable/htdocs/artefact/annotation/lib.php:1294
      ArtefactTypeAnnotationfeedback::add_annotation_feedback_form(object(ArtefactTypeAnnotation), object(View), null, "1061", false, "0") at /home/kristina/code/1610stable/htdocs/artefact/annotation/lib.php:1132
      ArtefactTypeAnnotationfeedback::get_annotation_feedback_for_view(object(ArtefactTypeAnnotation), object(View), "1061", true, false) at /home/kristina/code/1610stable/htdocs/artefact/annotation/blocktype/annotation/lib.php:134
      PluginBlocktypeAnnotation::render_instance(object(BlockInstance)) at Unknown:0
      call_user_func_array(array(size 2), array(size 1)) at /home/kristina/code/1610stable/htdocs/lib/mahara.php:1730
      call_static_method("PluginBlocktypeAnnotation", "render_instance", object(BlockInstance)) at /home/kristina/code/1610stable/htdocs/blocktype/lib.php:1007
      BlockInstance->render_viewing(false) at /home/kristina/code/1610stable/htdocs/lib/view.php:2037
      View->build_column(1, 1, false, false) at /home/kristina/code/1610stable/htdocs/lib/view.php:1991
      View->build_columns(1, false, false) at /home/kristina/code/1610stable/htdocs/lib/view.php:1976
      View->build_rows() at /home/kristina/code/1610stable/htdocs/view/view.php:281

  ----

  If possible, the annotations should be linked to the map in the copied
  collection. Currently, the annotations display on the page, but their
  status doesn't shop up on the smartEvidence overview page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1629144/+subscriptions