mahara-contributors team mailing list archive

[Mahara Bot <1618317@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/6905
Committed: https://git.mahara.org/mahara/mahara/commit/e99d7b5063cfe47b16f8fabc30c2e0fd0afa9cd0
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit e99d7b5063cfe47b16f8fabc30c2e0fd0afa9cd0
Author: Son Nguyen <son.nguyen@xxxxxxxxxxxxxxx>
Date:   Wed Aug 31 08:21:29 2016 +1200

Bug 1618317: Validate urlquerystr before parsing

Also update the tinymce/README.Mahara as TinyMCE imagebrowser plugin
is a part of mahara

behatnotneeded

Change-Id: Ie6d3aa1bf80db9f9d52e3373bf407ab6bf8cafad

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1618317

Title:
  JS error when click 'Edit image' in TinyMCE editor

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  In Progress

Bug description:
  Version: master(16.10)

  I got the following javascript error when edit an external image link
  via TinyMCE

  plugin.js?v=9174:37 Uncaught TypeError: Cannot read property '0' of
  null

  Steps

  1. Login as an user
  2. In the Prodfile/Introduction, click 'Insert/edit image' button in TinyMCE editor
  3. Add a link to an image: https://mahara.org/theme/mahara-org/static/images/site-logo.png
  4. Click Submit
  5. Select the image
  6. Click 'Insert/edit image' button

  Expected result: you should see the pop-up 'Insert or select an image'

  Actual
   - you see the above error in browser console
   - No pop-up appears
   - The browser scroll bar disappears

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1618317/+subscriptions