mahara-contributors team mailing list archive

[Mahara Bot <1632917@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/7142
Committed: https://git.mahara.org/mahara/mahara/commit/07b798e8ec6b1532f1a6a3d080e552a5e52130d1
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 07b798e8ec6b1532f1a6a3d080e552a5e52130d1
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Tue Oct 18 13:42:46 2016 +1300

Bug 1632917: Respect usr_account_preference('theme') for page creation

Currently only sets new page to institution theme rather than what
theme you specified in account preferences.

behatnotneeded - visual difference

Change-Id: Ie3b5f852f2a059f6b7dab1a86f8e8cd3d35015a9
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1632917

Title:
  Page created in wrong institution theme

Status in Mahara:
  Fix Committed

Bug description:
  Tested on Mahara 16.10dev

  When you are a member of 2 or more institutions, you can switch the
  themes in your account settings page to the institution theme that you
  want to browse the site in.

  When you create a page though, one of the institution themes is chosen
  and in my case it wasn't the one of the institution I had selected.

  To replicate:

  1. Set up institutions "School" and "University" and give each a different theme, i.e. not the site theme.
  2. Set up a user who is a member in both institutions.
  3. Log in and in the account settings, choose the school theme.
  4. Create a page -> it takes on the school theme, which is correct.
  5. Switch the theme in the account settings to "University".
  6. The site displays in the university institution theme -> correct.
  7. Create a page -> The school theme is selected -> This is not correct. It should display the university theme.
  8. When you go to the page that you created under 4, it also still displays the school theme when it should show the university theme as that is your browsing theme.

  The theme displayed to the user when browsing the site or creating a
  page should always be the one selected in account settings as that is
  the only way to know what the user's preference is.

  This is unrelated to being able to choose a page theme. When that
  functionality is enabled, users should be able to "pin" a specific
  theme to a page, but only then. At all other times, the institution
  theme / theme chosen in their account settings page should be the one
  used for browsing their own portfolio.

  There is no way to switch the theme to a "new" / other institution
  when page themes aren't turned on (which they aren't always).

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1632917/+subscriptions