mahara-contributors team mailing list archive

[Mahara Bot <1534398@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/7173
Committed: https://git.mahara.org/mahara/mahara/commit/d642671130676d7aa6bafedec1acef2da0c79b79
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    16.10_STABLE

commit d642671130676d7aa6bafedec1acef2da0c79b79
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Tue Oct 4 13:19:51 2016 +1300

Bug 1534398: Allow user creation to respect the 'nousernames' setting

Created a new function get_raw_user_urlid() to fetch the correct string to
pass to generate_urlid()

behatnotneeded

Change-Id: I1901045ef8e89d224e1ab9556587224ff1d7e6a0
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit 9d7b93c7c2c818c15eaf47b927acf6d54d4239c4)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1534398

Title:
  Clean URLs created during user account creation, do not respect the
  "nousernames" setting

Status in Mahara:
  Fix Committed
Status in Mahara 1.10 series:
  Won't Fix
Status in Mahara 15.04 series:
  Confirmed
Status in Mahara 15.10 series:
  Confirmed
Status in Mahara 16.04 series:
  Confirmed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  See: https://mahara.org/interaction/forum/topic.php?id=7479

  If you activate the "Never display usernames" site setting, and turn
  on clean URLs, the clean URL for new users' profile pages will still
  contain their username.

  If you do "regerenate clean URLs", however, the newly created clean
  URLs will *not* have the usernames.

  This is because the method regenerateurls_submit() in cleanurls.php
  respects the $CFG->nousernames setting, but the other places that
  generate clean URLs on account creation do not:

  - User->create() in auth/user.php
  - create_user() in lib/user.php

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1534398/+subscriptions