← Back to team overview

mahara-contributors team mailing list archive

[Bug 1582967] Re: Comment deletion forms & buttons with non-unique IDs

 

** Changed in: mahara/16.10
       Status: Fix Committed => Fix Released

** Changed in: mahara
    Milestone: 16.10.0 => None

** Changed in: mahara
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1582967

Title:
  Comment deletion forms & buttons with non-unique IDs

Status in Mahara:
  Fix Released
Status in Mahara 15.04 series:
  Fix Released
Status in Mahara 15.10 series:
  Fix Released
Status in Mahara 16.04 series:
  Fix Released
Status in Mahara 16.10 series:
  Fix Released

Bug description:
  While working on Bug 1580499, I noticed that the forms and buttons for
  comment deletion all have the same ID. This specifically gets in the
  way of me using their IDs for some workarounds in the Behat tests, but
  also it's just bad HTML. According to the HTML spec, the "ID"
  attribute is meant to be unique in the whole page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1582967/+subscriptions


References