mahara-contributors team mailing list archive

[Robert Lyon <robertl@xxxxxxxxxxxxxxx>]

** Changed in: mahara
    Milestone: 16.10.1 => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1541165

Title:
  Hide the activity types that belong to disabled plugins

Status in Mahara:
  Confirmed

Bug description:
  In the "User settings -> Notifications" screen, and in the Inbox block
  config, the end user is shown all installed Activity types, even if
  they belong to plugins that are currently hidden.

  This matters specifically because the "Annotation" plugin is hidden by
  default. So it's not good practice to show end users settings related
  to this notification type it will be impossible for them to receive.

  The activity_type table has columns "plugintype" and "pluginname" to
  indicate when an activity belongs to a plugin. So, we should use that
  to check whether the associated plugin is disabled, when displaying a
  list of notification activity types to end users.

  It's still fine to show all activity types to admin users, although in
  those cases it may also make sense to gray out or otherwise indicate
  the inactivity of activity types associated with a disabled plugin.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1541165/+subscriptions