← Back to team overview

mahara-contributors team mailing list archive

[Bug 1636866] [NEW] auth/saml/lib.php breaks PHP 5.4 compatability

 

Public bug reported:

Hi,

I'm installing Mahara 16.10.0 on a server running PHP 5.4.45.

Line 453 of auth/saml/lib.php breaks compatibility with PHP 5.4
  
        if (empty(get_config('memcacheservers')) && !extension_loaded('memcache')) {

Prior to 5.5 this should be something like

        $memcacheservers_config = get_config('memcacheservers');
        if (empty($memcacheservers_config) && !extension_loaded('memcache')) {...}

Either auth/saml/lib.php needs changed or the README.md needs updated to
reflect that the required minimum version is now 5.5. I only spotted
this as my development server still runs 5.4, mu live server is on 5.6.

Kevin

** Affects: mahara
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1636866

Title:
  auth/saml/lib.php breaks PHP 5.4 compatability

Status in Mahara:
  New

Bug description:
  Hi,

  I'm installing Mahara 16.10.0 on a server running PHP 5.4.45.

  Line 453 of auth/saml/lib.php breaks compatibility with PHP 5.4
    
          if (empty(get_config('memcacheservers')) && !extension_loaded('memcache')) {

  Prior to 5.5 this should be something like

          $memcacheservers_config = get_config('memcacheservers');
          if (empty($memcacheservers_config) && !extension_loaded('memcache')) {...}

  Either auth/saml/lib.php needs changed or the README.md needs updated
  to reflect that the required minimum version is now 5.5. I only
  spotted this as my development server still runs 5.4, mu live server
  is on 5.6.

  Kevin

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1636866/+subscriptions


Follow ups