mahara-contributors team mailing list archive

[Mahara Bot <1607743@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/7215
Committed: https://git.mahara.org/mahara/mahara/commit/961ae5443285503f0d3358bb993fad175ed15c1f
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 961ae5443285503f0d3358bb993fad175ed15c1f
Author: Pat Kira <pat.kira@xxxxxxxxxxxxxxx>
Date:   Fri Oct 28 16:42:30 2016 +1300

Bug 1607743 Fix page theme comflicting with configuarable theme

When configurable theme is set as well as page theme.
The page displays a mix of styles (configurable styles and page styles).

We only want the page to have the specified page theme.

Change-Id: Ifa2e998d864c86df9ffb70dd68c0abcc52088e13
behatnotneeded: styling only

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1607743

Title:
  Page themes don't work with configurable theme

Status in Mahara:
  Fix Committed

Bug description:
  Master mahara (but also on 16.04 and 15.10)

  When users can choose a theme for their pages and the institution uses
  the configurable theme, nothing is being displayed properly.

  Part of the configurable theme is always visible but the acutal chosen
  theme is used for the navigation, which does not look good. And then
  putting skins on top...

  To replicate the issue:

  1. Allow users to choose page themes: Admin -> Configure site -> User settings -> Users can choose page themes.
  2. Create an institution and choose the configurable theme. Choose a dark background color so that header nav items need to be white.
  3. Add a user to that institution.
  4. Set up a page as that user and give it a different theme.
  Expected result: The theme overwrites the configurable theme completely like it does when a an institution has a regular theme.
  Actual result: Part of the configurable theme is still visible (see screenshot).

  The screenshot also shows how it would look like with a skin. The skin
  doesn't influence it badly though. Just something to keep in mind for
  testing.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1607743/+subscriptions