← Back to team overview

mahara-contributors team mailing list archive

[Bug 1643365] A patch has been submitted for review

 

Patch for "master" branch: https://reviews.mahara.org/7266

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1643365

Title:
  LeapImportArtefactPlugin warning when extending class adds parameters
  in method

Status in Mahara:
  In Progress

Bug description:
  When trying to import a Leap2A file, the operation in successful but
  shows following warning for several classes:

  [WAR] de (artefact/resume/import/leap/lib.php:0) Declaration of
  LeapImportResume::import_author_data(PluginImport $importer,
  $persondataid) should be compatible with
  LeapImportArtefactPlugin::import_author_data(PluginImportLeap
  $importer, $persondataid)

  [WAR] de (artefact/plans/import/leap/lib.php:0) Declaration of
  LeapImportPlans::setup_relationships(SimpleXMLElement $entry,
  PluginImportLeap $importer) should be compatible with
  LeapImportArtefactPlugin::setup_relationships(SimpleXMLElement $entry,
  PluginImportLeap $importer, $strategy, array $otherentries)

  [WAR] de (artefact/annotation/import/leap/lib.php:0) Declaration of
  LeapImportAnnotation::setup_view_relationships(SimpleXMLElement
  $entry, PluginImportLeap $importer) should be compatible with
  LeapImportArtefactPlugin::setup_view_relationships(SimpleXMLElement
  $entry, PluginImportLeap $importer, $strategy, array $otherentries)

  [WAR] de (artefact/comment/import/leap/lib.php:0) Declaration of
  LeapImportComment::setup_relationships(SimpleXMLElement $entry,
  PluginImportLeap $importer) should be compatible with
  LeapImportArtefactPlugin::setup_relationships(SimpleXMLElement $entry,
  PluginImportLeap $importer, $strategy, array $otherentries)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1643365/+subscriptions


References