mahara-contributors team mailing list archive

[Mahara Bot <1642745@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/7258
Committed: https://git.mahara.org/mahara/mahara/commit/ec7dde1c31f04546d3671ad5d34941b103685b1f
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit ec7dde1c31f04546d3671ad5d34941b103685b1f
Author: Cecilia Vela Gurovic <cecilia@xxxxxxxxxxxxxxx>
Date:   Fri Nov 18 11:44:36 2016 +1300

Bug 1642745: Fix error Only variables should be passed by reference

Fixed error when

accessing page webservice/testclient.php
that showed a debug message "Only variables should
be passed by reference".

importing Leap2A file that showed same message.

behatnotneeded

Change-Id: I44d1bbb4303fcf50d633e62ff2e316cf28fa3c47

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1642745

Title:
  Error: Only variables should be passed by reference

Status in Mahara:
  Fix Committed

Bug description:
  When I go to page webservice/testclient.php

  I see the error debug message:

  "Only variables should be passed by reference"

  This is coming from a call to array_shift() that has a call to
  array_keys() as a parameter.

  We should assign the result from array_keys() to a variable and then
  call array_shift() with this variable as a parameter.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1642745/+subscriptions