mahara-contributors team mailing list archive

[Mahara Bot <1644649@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/7271
Committed: https://git.mahara.org/mahara/mahara/commit/b517ee2c00b2ea1029eb582bd6830708a78c226b
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit b517ee2c00b2ea1029eb582bd6830708a78c226b
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Fri Nov 25 11:19:36 2016 +1300

Bug 1644649: Fixing bad secret url checking sql queries

The sql queries were missing the COUNT() parameter, but it turns out
we should just use record_exists_select in this case as we don't care
how many exist but if they do or not.

behatnotneeded

Change-Id: Ice7cbb619701e32fd11030cd7f69e9fba0609a34
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1644649

Title:
  Bad call to count_records_sql() for collection views

Status in Mahara:
  Fix Committed
Status in Mahara 16.10 series:
  In Progress
Status in Mahara 17.04 series:
  Fix Committed

Bug description:
  In Mahara we have a db call called count_records_sql() that uses a
  passed in sql query.

  It fetches a result set via get_recordset_sql() then calls reset()
  which fails if the result set is false.

  Normally we use count_records_sql() with a query containing the sql
  COUNT() option so that it always returns a non false result.

  But this is not obvious when using this function.

  So I'll fix up the bad call to this function and put some notes in it
  about needing to use COUNT() in sql query string

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1644649/+subscriptions