mahara-contributors team mailing list archive

[Mahara Bot <1638733@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/7278
Committed: https://git.mahara.org/mahara/mahara/commit/912b9279cd129a81dc02a61597a2bc90390f126b
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    16.10_STABLE

commit 912b9279cd129a81dc02a61597a2bc90390f126b
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Thu Nov 3 11:25:19 2016 +1300

Bug 1638733: Static pages save - need to check if element is present

On institution static pages we have the 'use default' option but that
is not present on the site static pages

So we need to check for it correctly in javascript

behatnotneeded

Change-Id: Ifb063083dc5e77f890441f269478d3e9e851be4e
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit de61fbccc484382a88a1a7a2500e3f74ed6d6095)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1638733

Title:
  Static pages gives js error

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed

Bug description:
  I get this error:

  TypeError: $(...) is null
   if ($('editsitepage_pageusedefault').checked == true) {

  This is because the 'use default' option is not present on the site
  static pages but is on the institution static pages.

  Need to detect if the element exists before trying to find it's
  'checked' status

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1638733/+subscriptions