mahara-contributors team mailing list archive

[Mahara Bot <1636599@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/7214
Committed: https://git.mahara.org/mahara/mahara/commit/255d49a03db273d72060851a25c6e33b30b7a3ef
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 255d49a03db273d72060851a25c6e33b30b7a3ef
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Wed Oct 26 08:28:47 2016 +1300

Bug 1636599: Avoid infinite redirect with user journals pages

Where a user has multiple journals but has account preference for
multiple blogs turned off.

To test: Add multiple blogs to a user then in db set the user
preference for multiple blogs to off. Logout and login again as the
user and go to the journals page.

behatnotneeded

Change-Id: I2612e8d9d8c2adde5e35d972269b70353de6c9aa
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1636599

Title:
  Infinite redirect loop with journals page

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  Reported on forums:
  https://mahara.org/interaction/forum/topic.php?id=7758&offset=0&limit=10#post31230

  When clicking on the Content/Blogs tab I get a browser error: "too many redirects". 
  Resetting the browser(s) settings (deleting cookies and such) didn't solve the issue.

  ------

  This problem looks to be due to this situation.

  A user has multiple blogs in their journal section but for some reason
  they are either missing the setting 'multipleblogs' in the
  usr_account_preference table in the database or that the setting is
  set to '0' (off).

  On the page that shows the singular journal there is a check to see if
  user has more than 1 journal and redirects them to multiple journals
  page if so.

  On the multiple journals page there is a check to see if the user's
  account preference is set to multiple blogs and if not sent them to
  the singular journal page.

  And so we end up in an redirect loop.

  What is needed is on the multiple journals page to check if we have
  multiple journals existing and not the user preference and if so to
  alert them of this fact and get them to turn on the preference in
  their account settings

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1636599/+subscriptions