mahara-contributors team mailing list archive

[Gilles-Philippe Leblanc <gilles-philippe.leblanc@xxxxxxxxxxxx>]

The fix seems OK but it is not correct.
It add now two margin-bottom to each element but the first one.
Its not visible only because the two bottom margin overlap.
* Go to developer mode on your browser (F12) and go see the file picker.
* You will see that each picker picker but the first are surrounded by a div.file-wrapper.

Hopefully, the two bottom-margin is only applied one that why you don't
see the problem but that why I don't think the actual fix is the best.

I just committed mines. It modify the html and the class to correctly
use the file wrapper. This way, the first file-picker is wrapped in the
<div class="file-wrapper"> like the other added after.

I putted two fix. One with my patch and the second with the remove of
the first fix already merged.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1648131

Title:
  The bottom margin of the first file picker is different of the other
  filepickers

Status in Mahara:
  Fix Committed

Bug description:
  To reproduce:
  * Click on the menu: Content > Resume
  * On the "Education history" section, click on the "Add" button
  * Then, click on the "Add attachment" button 3 times

  Expected: The margin between the first file picker may be equal of the
  margin between the others file pickers.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1648131/+subscriptions