mahara-contributors team mailing list archive

[Robert Lyon <robertl@xxxxxxxxxxxxxxx>]

Public bug reported:

Sometimes when a user shares a collection with a group they belong to
that collection doesn't show in the list for 'Collections shared with
this group' in the Group pages block.

The reason for this is because the sql for the list only fetches the
collection_view page with displayorder = 0

This is so it fetches the first page so can get the url for collection
and also limit the results to once per collection.

The problem occurs when one deletes the first page from a collection via
the edit collections views page.

It doesn't reset the collection views display order and so there is no
displayorder = 0

A workaround for this could be to change the line in lib/view.php for
get_sharedcollections_data()

from
                AND (cv.displayorder = 0 OR cv.displayorder IS NULL)
to
                AND (cv.displayorder = (SELECT MIN(displayorder) FROM collection_view WHERE collection = c.id) OR cv.displayorder IS NULL)

where it fetches the minimum display order value

Or fix up the deletion of views from collection so that the displayorder
is reset correctly

** Affects: mahara
     Importance: High
         Status: Confirmed

** Changed in: mahara
       Status: New => Confirmed

** Changed in: mahara
   Importance: Undecided => High

** Changed in: mahara
    Milestone: None => 17.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1655456

Title:
  Sharing collection with a group not showing on group homepage list

Status in Mahara:
  Confirmed

Bug description:
  Sometimes when a user shares a collection with a group they belong to
  that collection doesn't show in the list for 'Collections shared with
  this group' in the Group pages block.

  The reason for this is because the sql for the list only fetches the
  collection_view page with displayorder = 0

  This is so it fetches the first page so can get the url for collection
  and also limit the results to once per collection.

  The problem occurs when one deletes the first page from a collection
  via the edit collections views page.

  It doesn't reset the collection views display order and so there is no
  displayorder = 0

  A workaround for this could be to change the line in lib/view.php for
  get_sharedcollections_data()

  from
                  AND (cv.displayorder = 0 OR cv.displayorder IS NULL)
  to
                  AND (cv.displayorder = (SELECT MIN(displayorder) FROM collection_view WHERE collection = c.id) OR cv.displayorder IS NULL)

  where it fetches the minimum display order value

  Or fix up the deletion of views from collection so that the
  displayorder is reset correctly

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1655456/+subscriptions