mahara-contributors team mailing list archive

[Pat <pat.kira@xxxxxxxxxxxxxxx>]

Firstly, navigation position (or styles) relies on a class which is
added by "siteMessages" function in theme.js. The function counts the
number of site messages and adds message-count-{number} class on header
element (.header) and main navigation (.main-nav). And this is true for
"raw" and core themes.

However in Mahara.org 16.04 upgrade, there where some changes in the
templates to make 16.04 look like how it was before as a result I had to
changed selectors in mahara-org theme js to get the site message styles
to behave correctly. When we updated to 16.10 (current theme), the
template especially markups around navigation were changed, there were
some consolidations around user navigation and the main navigation is on
the page content rather than being below header. The issue you have
mentioned above is rather specific to mahara.org theme (I have submitted
a patch for that).

As for Mahara core, I can add a note in the documentation about how
fixed header with site messages should be styled since there are 3
places (js, markup and css) to consider if one is changed.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1651913

Title:
  Top info messages should not be pushing content incorrectly

Status in Mahara:
  Confirmed

Bug description:
  When you have a fixed header for your Mahara site and it is wider than
  the default one, content below it should still be displayed correctly
  and not covered. Currently, when you have productionmode = false or
  masquerade as someone, the header is pushed down, but the flexible
  content area is not and thus not all content is shown.

  There should be a general fix for that as not all themes require it,
  but if someone builds a custom theme using raw or another theme as
  basis, they shouldn't have to worry about it.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1651913/+subscriptions