mahara-contributors team mailing list archive

[Mahara Bot <1648679@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/7386
Committed: https://git.mahara.org/mahara/mahara/commit/4c36ab05050572bf677a8ad190045ccfe3eb86e7
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    16.10_STABLE

commit 4c36ab05050572bf677a8ad190045ccfe3eb86e7
Author: Cecilia Vela Gurovic <cecilia@xxxxxxxxxxxxxxx>
Date:   Fri Dec 9 16:11:16 2016 +1300

Bug 1648679: Avoiding "Passed by reference" error

Fixed lines of code that threw the error
"Only variables should be passed by reference"
and other errors found.

behatnotneeded

Change-Id: I23e6a3c1b2ef97bf2cae29c15814fcdb79d5676f
(cherry picked from commit c29f4ef478efd7af27680c4ad4b769f7c2e59fe7)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1648679

Title:
  Find all Errors in code: Only variables should be passed by reference

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed

Bug description:
  Need to search and fix all lines of code that throw error:
  "Only variables should be passed by reference"

  this message is shown when a function is called that needs parameters passed by reference but instead of a variable, another function called is passed. In most cases it works, but as it says here 
  https://bugs.php.net/bug.php?id=48937 this might lead to memory corruptions in some cases.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1648679/+subscriptions