mahara-contributors team mailing list archive

[Mahara Bot <1648679@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/7461
Committed: https://git.mahara.org/mahara/mahara/commit/6688838ea92624662ed6320debfc54e6cef228ed
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    16.04_STABLE

commit 6688838ea92624662ed6320debfc54e6cef228ed
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Tue Jan 24 14:34:51 2017 +1300

Bug 1648679: Avoiding "Passed by reference" error

In the add secretURL for a collection

behatnotneeded

Change-Id: If00893b96f38f9442ddd718dd2a39f245c839f84
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit d0df443b314553d1397872b71b1d72aa0a06217b)
(cherry picked from commit 2cfe588e5b01cb8fae2d3eeb12791939eb2ab9a9)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1648679

Title:
  Find all Errors in code: Only variables should be passed by reference

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed

Bug description:
  Need to search and fix all lines of code that throw error:
  "Only variables should be passed by reference"

  this message is shown when a function is called that needs parameters passed by reference but instead of a variable, another function called is passed. In most cases it works, but as it says here 
  https://bugs.php.net/bug.php?id=48937 this might lead to memory corruptions in some cases.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1648679/+subscriptions