mahara-contributors team mailing list archive

[Mahara Bot <1387858@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/7516
Committed: https://git.mahara.org/mahara/mahara/commit/194f49219561f8257c9b79364b5861440ad9a271
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    16.10_STABLE

commit 194f49219561f8257c9b79364b5861440ad9a271
Author: Cecilia Vela Gurovic <ceciliavg@xxxxxxxxxxxxxxx>
Date:   Tue Feb 21 15:23:47 2017 +1300

Bug 1666099: Draft journal entries should be hidden

When a journal entry is marked as draft,
we can't add it to a block
we don't show it in a page, instead we show a
placeholder with a message
see bug 1387858

Change-Id: I73c475bbc6baddc0dc38c9e7a2c3c60b24a617b4
behatnotneeded
(cherry picked from commit 6eb1dde2e5eeb8c258f936ad9785a5cda9bcee2e)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1387858

Title:
  Draft journal entries are visible to others

Status in Mahara:
  Fix Released
Status in Mahara 1.10 series:
  Fix Released
Status in Mahara 1.8 series:
  Fix Released
Status in Mahara 1.9 series:
  Fix Released

Bug description:
  confirmed for master (15.04), 1.10, 1.9 and 1.8

  When a user creates a journal entry as draft and puts that into a
  page, it is also visible to other users when they have access to the
  page.

  When the user puts the entire journal into a page (or tagged journal
  entries), the draft entry is not visible because it is in draft
  status.

  There are two possibilities as far as I can see right now:

  1.
  Do not allow users to include journal entries that are in draft status into a page (and mention that in the block pop-up so they don't wonder why draft entries do not show up).

  2. 
  The block "Journal entry" needs to be changed so that draft entries are only visible to the author at most but not other users on the page. This should also include some visual indicator as we have in the journal itself for the draft. "Draft" could also be mentioned next to the title of the journal entry when selecting it in the block pop-up.

  I tend towards option 1 as that is cleaner and more in line with the
  behavior of the other blocks. We should then also mention on the other
  blocks that draft entries are not displayed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1387858/+subscriptions