mahara-contributors team mailing list archive

[Mahara Bot <1658389@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/7581
Committed: https://git.mahara.org/mahara/mahara/commit/97ab1378a8406f9ee39129ac35bb579595865ccf
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 97ab1378a8406f9ee39129ac35bb579595865ccf
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Thu Mar 30 13:37:31 2017 +1300

Bug 1658389: 'Copy' for group admins that are allowed to create groups

We should only show the 'Copy' button to group admins that respect the
rules set in the Admin -> Config -> Group settions -> Create groups
field.

behatnotneeded

Change-Id: I8698f101fd90ea74e230c3c8ed0050f06b6ab03c
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1658389

Title:
  Show group "Copy" button only when permission to create groups

Status in Mahara:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  Mahara 16.10:

  The group "Copy" button is visible to admins even when they are not
  allowed to create a group. Since copying a group is essentially
  creating a group, the config site's group settings should be
  respected.

  To replicate:

  1. Create 5 group manually (not via CSV).
  2. Assign a regular member, an institution staff, an institution admin, a site admin to one group each as group admin. Assign all 4 to the 5th group as admins.
  3. Set Admin -> Configure site -> Site options -> Group settings -> Create groups to each of the options and check the groups that only the roles selected see the group copy button and can copy the group (click the copy button and observe what happens; don't just see the copy button).

  The issue around copying groups created by CSV is outlined in bug
  #1658393.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1658389/+subscriptions