mahara-contributors team mailing list archive

[Aaron Wells <1681282@xxxxxxxxxxxxxxxxxx>]

Hi all,

Mahara language strings are actually sprintf() format strings. That's
why the placeholder is "%s". Thus if you want to print a literal "%"
character, you have to sprintf-escape it by doing two of them: "%%".

So the fix here is to update the Japanese language pack so that this
language-string has a %% instead of a %.

<strong class="error text-danger">Cronが動作していません。</strong><br
/>cronのセットアップに関するインストラクションは<a
href="https://wiki.mahara.org/wiki/System_Administrator%%27s_Guide/Installing_Mahara";>installation
guide</a>をご覧ください。あなたがすでにcronをセットアップしている場合、直近の1つまたはそれ以上の処理が正しく実行されませんでした。

... or in this case, you could alternately update the Japanese language
pack to replace the "%27" with a an apostrophe "'". That's what we did
in the English language pack, as a less-brittle fix for this particular
string.

I'll update the wiki page about lang strings (
https://wiki.mahara.org/wiki/Developer_Area/Language_strings#Plural_strings
). Currently it mentions sprintf(), but it doesn't explicitly say that
lang strings are sprintf() format strings, or that you have to escape
literal % characters.

Cheers,
Aaron

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1681282

Title:
  warning message when using japanese language pack

Status in Mahara:
  In Progress
Status in Mahara 17.10 series:
  Confirmed

Bug description:
  Install japanese language pack
  go to admin/index.php
  refresh the page

  you will see a warning message:
   [WAR] b4 (lib/mahara.php:1470) sprintf(): Too few arguments

  This is happening because the function sprintf has a string parameter
  containing a '%' symbol that makes the function expect an extra
  string, but the symbol is in fact part of an URL.

  
  parameter string: 
   <strong class="error text-danger">Cronが動作していません。</strong><br />cronのセットアップに関するインストラクションは<a href="https://wiki.mahara.org/wiki/System_Administrator%27s_Guide/Installing_Mahara";>installation guide</a>をご覧ください。あなたがすでにcronをセットアップしている場合、直近の1つまたはそれ以上の処理が正しく実行されませんでした。

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1681282/+subscriptions