← Back to team overview

mahara-contributors team mailing list archive

[Bug 1681579] A change has been merged

 

Reviewed:  https://reviews.mahara.org/7660
Committed: https://git.mahara.org/mahara/mahara/commit/d5e858982cfd0148cbbda3e7c69ed567e964127b
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    17.04_STABLE

commit d5e858982cfd0148cbbda3e7c69ed567e964127b
Author: Pat Kira <pat.kira@xxxxxxxxxxxxxxx>
Date:   Tue Apr 11 13:42:33 2017 +1200

Bug 1681579 - Added svg support for mahara logo

- Make svg of supported extension.
- Add svg versions of Mahara logo to all core themes including footer
logo.
- Tidied up upgrade footer styles and templates as well as using
theme_image_url instead of image path with specific file extension.

Note 1: We are not removing exisiting png version of both logos just
in case someone needs it or want to use it.

Fixed configurable custom logo display
- Check if there is a custom logo if so add to data attribute on the
template.
- Add a check in js if there's custom logo we won't replace the logo

Note 2: Displaying correct version of Mahara logo based on header
background could be done at the backend (PHP) since the background value
stored in the database (I think).

behatnotneeded

Change-Id: I377401a9477e3b06e9fcee366579bbfc09bc73ea
(cherry picked from commit 4078c8d5c52bbfd7e021b1b54b2db1d1361dc391)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1681579

Title:
  Put the Mahara logo into the themes as SVG file

Status in Mahara:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed

Bug description:
  for Mahara 17.04 and master (we'll leave the PNGs for earlier
  versions):

  use SVG instead of PNG to allow for crisper quality of the logo.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1681579/+subscriptions


References