mahara-contributors team mailing list archive
-
mahara-contributors team
-
Mailing list archive
-
Message #41998
[Bug 1658393] A change has been merged
Reviewed: https://reviews.mahara.org/7665
Committed: https://git.mahara.org/mahara/mahara/commit/0524e22037f108949c19eb23570680354e56f402
Submitter: Aaron Wells (aaronw@xxxxxxxxxxxxxxx)
Branch: master
commit 0524e22037f108949c19eb23570680354e56f402
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date: Fri Apr 21 09:03:05 2017 +1200
Bug 1658393: Respect group copying rules
When copying (therefore creating) a group owned by an institution
we check if user can edit institution - if not we set institution
to 'mahara'
behatnotneeded
Change-Id: I648d74a70016d4b68e738147cc63952ec8261926
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1658393
Title:
Can't copy group created by CSV when not an admin
Status in Mahara:
Confirmed
Status in Mahara 16.10 series:
Confirmed
Status in Mahara 17.04 series:
Confirmed
Status in Mahara 17.10 series:
In Progress
Bug description:
Mahara 16.10+
This bug is related to bug #1658389 and should be fixed along with it.
In 16.10 we added the possibility to copy a group and also manage all
groups via CSV file. Institution and site admins can copy a group
without problems, but an institution member that doesn't have the
institution admin role cannot copy a group created within an
institution and only sees an error message.
To replicate:
1. Create institution "uni" and create 3 users in it: One institution admin "InstAdmin", one a regular member "User", one a staff member "Staff".
2. As institution or site admin create the group "Practicum uni" in the institution "uni" via CSV.
3. As institution or site admin create the group "support" manually (NOT via CSV).
3. Assign both "InstAdmin" and "User" as group admins to the groups "Practicum uni" and "Support".
4. Under Configure site -> Site options -> Group settings make sure that "Create group" is set to "Everyone.
3. Log in as "User".
4. Click the "Copy" button on group "Practicum uni". Expected result: The user can copy the group as he has group creation permissions. Actual result: But he gets the error message that he can't create a group in the institution.
5. Click the "Copy" button on group "Support". Expected and actual result: The user can copy the group.
6. Log in as "Staff".
7. Click the "Copy" button on group "Practicum uni". Expected result: The user can copy the group as he has group creation permissions. Actual result: But he gets the error message that he can't create a group in the institution.
8. Click the "Copy" button on group "Support". Expected and actual result: The user can copy the group.
9. Log in as "InstAdmin".
10. Click the "Copy" button on group "Practicum uni". Expected and actual result: The institution admin can copy the group.
11. Click the "Copy" button on group "Support". Expected and actual result: The institution admin can copy the group.
12. Repeat with the other two "Create group" options.
Institution admins can copy a CSV file created group in their
institution because they can also do so in the administration area.
The other two roles, users and staff cannot. They can only copy groups
that are in "No institution" even when they have group copying
permissions.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1658393/+subscriptions
References