mahara-contributors team mailing list archive

[Mahara Bot <1686226@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/7696
Committed: https://git.mahara.org/mahara/mahara/commit/a5ef3bb0240677b81996b0914ddb2f6fca8ea801
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    16.10_STABLE

commit a5ef3bb0240677b81996b0914ddb2f6fca8ea801
Author: Cecilia Vela Gurovic <ceciliavg@xxxxxxxxxxxxxxx>
Date:   Wed Apr 26 10:34:18 2017 +1200

Bug 1686226: fix for php7 error warning for license block

behatnotneeded

Change-Id: Ib5517ea506dddd63ccf449f17e0244bf71c062f5
(cherry picked from commit fb2671afa04307038eadefbecae43349b61378bb)
(cherry picked from commit 6b56d7c1deff2d4a72958fbbed7925705a813006)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1686226

Title:
  License block - Only variables should be passed by reference

Status in Mahara:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed

Bug description:
  Only variables should be passed by reference error when adding a
  Creative Commons License to a page

  - Create a page
  - In General menu, choose Creative common license block and add it to the page
  - Save
  - Display page

  Then we have the error message:

  [WAR] 5d (blocktype/creativecommons/lib.php:45) Only variables should be passed by reference
  Call stack (most recent first):

      log_message("Only variables should be passed by reference", 8, true, true, "/home/ceciliavg/maharacode/maharatest/htdocs/block...", 45) at /home/ceciliavg/maharacode/maharatest/htdocs/lib/errors.php:521
      error(8, "Only variables should be passed by reference", "/home/ceciliavg/maharacode/maharatest/htdocs/block...", 45, array(size 4)) at /home/ceciliavg/maharacode/maharatest/htdocs/blocktype/creativecommons/lib.php:45
      PluginBlocktypeCreativecommons::render_instance(object(BlockInstance), true) at /home/ceciliavg/maharacode/maharatest/htdocs/lib/mahara.php:1771
      call_static_method("PluginBlocktypeCreativecommons", "render_instance", object(BlockInstance), true) at /home/ceciliavg/maharacode/maharatest/htdocs/blocktype/lib.php:895
      BlockInstance->render_editing(false, false, true) at /home/ceciliavg/maharacode/maharatest/htdocs/blocktype/lib.php:823
      BlockInstance->instance_config_store(object(Pieform), array(size 2)) at /home/ceciliavg/maharacode/maharatest/htdocs/lib/pieforms/pieform.php:543
      Pieform->__construct(array(size 15)) at /home/ceciliavg/maharacode/maharatest/htdocs/lib/mahara.php:4804
      pieform_instance(array(size 15)) at /home/ceciliavg/maharacode/maharatest/htdocs/blocktype/lib.php:1219
      BlockInstance->build_configure_form(true) at /home/ceciliavg/maharacode/maharatest/htdocs/view/blocks.php:72

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1686226/+subscriptions